Bitpackingv2 #307
Merged
Bitpackingv2 #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/307
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d9a94c8 with merge base 6a380a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
requested changes
Jun 3, 2024
msaroufim
reviewed
Jun 3, 2024
gau-nernst
reviewed
Jun 3, 2024
|
Per cuda mode chat, let's just fix the merge conflict and ensure the perf isn't regressed on some microbenchmarks relative to code in main |
msaroufim
reviewed
Jun 10, 2024
msaroufim
reviewed
Jun 10, 2024
msaroufim
reviewed
Jun 10, 2024
msaroufim
requested changes
Jun 10, 2024
msaroufim
approved these changes
Jun 10, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* untested unified pack/unpack * tests written, issues fixed * removed conversion * works with compile + use pytest params * added hqq int4 fp16 mixed matmul benchmark for pack * added more repeats for benchmark and removed unused vars * added 1 more benchmark and now tests pass * added order to unpack and updated tests * removed main code and added a text example * added example * organized benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved code structure of the pack/unpack functions
Now supports trinary for bitnet applications
Now supports packing along any dimension for any size tensors
Now supports packing/unpacking elements such that lower indexed elements can be placed in the highest order bits or lowest order bits in the container