-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graceful handling of cpp extensions #296
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/296
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit ac44a52 with merge base 4c1d568 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Failure in CI seems unrelated so review would still be helpful |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On wsl2:
USE_CPP=0 pip install -e. runs into https://pastebin.com/CMhYTn20
but USE_CPP=0 python setup.py develop works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip installing wheel fixed this issue. Maybe add this to dev-requirements.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Still not sure why some people still face problems. Without a reproducible way to trigger the problems, it is hard to see what would solve them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the standard should be, but I know other tests (ex. quantization) import some boolean like "TORCH_VERSION_AFTER_2_4" and use that instead of a try except block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main problem is we are not sure why/when the import fails, so the boolean probably won't help here..
* Graceful handling of cpp extensions * update * push * yolo * revert some changes' * Update __init__.py * Update README.md ---------
This fixes issues from #288
More specifically
USE_CPP=0 pip install .
this is useful out of convenience for faster iteration cyclesimport torchao
from insidetorchao/