Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP6-LLM] Port splitK map from DeepSpeed #283

Merged
merged 2 commits into from
May 29, 2024

Conversation

gau-nernst
Copy link
Collaborator

Copy link

pytorch-bot bot commented May 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/283

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b89ec10 with merge base 42c2376 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 26, 2024
@@ -111,6 +112,143 @@ def from_tc_float6_e3m2(tensor: Tensor, M: int, N: int, dtype: torch.dtype = tor
return from_float6_e3m2(tensor_fp6, no_bit_packing=True, dtype=dtype)


# https://github.com/microsoft/DeepSpeed/blob/3a3a6db3332e339cc9fd94efd4982f6d60635a3d/deepspeed/inference/v2/kernels/core_ops/cuda_linear/cuda_linear.py
_SPLIT_K_MAP = [
{ # tokens: [1, 64]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n00b q: what is meant by token counts here?

Also can these values be autotuned? I don't necesarily wanna merge in something that's only fast on A100

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the batch size. Yea, it will be great if we can autotune CUDA kernel also.

@msaroufim msaroufim self-requested a review May 29, 2024 01:58
@msaroufim msaroufim merged commit 6dd63b8 into pytorch:main May 29, 2024
13 checks passed
@gau-nernst gau-nernst mentioned this pull request May 29, 2024
@gau-nernst gau-nernst deleted the fp6_llm_splitk_map branch May 29, 2024 03:59
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* aoti runner test

* change to cpu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants