Don't call erase if node is already erased in batch norm fusion. #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The erase call results in a warning log if the node is already erased by the dead code elimination earlier. Checking if the node is already erased so we don't unnecessarily pollute the log with warnings. Differential Revision: D79846881
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2716
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 405f04e with merge base 1114ca0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D79846881 |
|
Not sure how to add a topic label. I don't think I have the permission. |
jerryzh168
added
the
topic: improvement
jerryzh168
approved these changes
Aug 7, 2025
liangel-02
pushed a commit
that referenced
this pull request
Aug 25, 2025
Differential Revision: D79846881 Pull Request resolved: #2716
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The erase call results in a warning log if the node is already erased by the dead code elimination earlier.
Checking if the node is already erased so we don't unnecessarily pollute the log with warnings.
Differential Revision: D79846881