Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename nightly-build.yml to build.yml #240

Merged
merged 8 commits into from
May 14, 2024
Merged

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented May 14, 2024

Let me merge this PR

So this github action makes it possible to push out our latest release binaries on pypi while also still doing our nightly releases by navigating to this tab https://github.com/pytorch/ao/actions/workflows/nightly-build.yml

The key changes are

  1. An optional ref argument to the github action where we'd pass in a branch a branch name e.g v0.02
  2. A flag for either release or nightly. Nightly is the default
  3. Install our dependencies like requirements.txt otherwise CI was breaking with missing torch dependency
  4. Because we missed this error for 3 weeks adding a louder notification on issues if we miss this

Copy link

pytorch-bot bot commented May 14, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/240

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (6 Unrelated Failures)

As of commit 2b218d4 with merge base 7734f79 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 14, 2024
@msaroufim msaroufim requested a review from cpuhrsch May 14, 2024 21:19
@msaroufim msaroufim merged commit 6af40e5 into main May 14, 2024
3 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-7 branch May 14, 2024 21:22
lancerts pushed a commit to lancerts/ao that referenced this pull request May 17, 2024
* Update and rename nightly-build.yml to build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
* Update and rename nightly-build.yml to build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml

* Update build.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants