Don't import _C in fbcode #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
msaroufim
reviewed
May 6, 2024
torchao/__init__.py
Outdated
| from torch.testing._internal.common_utils import IS_FBCODE | ||
| if not IS_FBCODE: | ||
| from . import _C | ||
|
|
||
| from . import ops |
There was a problem hiding this comment.
Might need to also bring this in under IS_FBCODE flag
And also will need to skip this test https://github.com/pytorch/ao/blob/main/test/test_ops.py
Test plan is internal CI I guess so will review on phabricator
There was a problem hiding this comment.
I'll probably need to test this in the fbcode-oss sync diff, since if I just import this PR it may not work since currently code base is not synced
Summary: since we don't have compilation command in fbcode, and we don't need to use cuda kernels right now in fbcode Test Plan: internal CI Reviewers: Subscribers: Tasks: Tags:
msaroufim
approved these changes
May 6, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
Summary: since we don't have compilation command in fbcode, and we don't need to use cuda kernels right now in fbcode Test Plan: internal CI Reviewers: Subscribers: Tasks: Tags:
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
To enable dispatching via GitHub UI for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
since we don't have compilation command in fbcode, and we don't need to use cuda kernels right now in fbcode
Test Plan:
internal CI
Reviewers:
Subscribers:
Tasks:
Tags: