Skip to content

[testing]Triaging ROCm wheel build #2161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

[testing]Triaging ROCm wheel build #2161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e389cc5
Enable ROCm support in build workflow and specify runner configuratio…
May 1, 2025
31c3c4c
Refactor HIP source directory handling in setup.py and remove depreca…
May 8, 2025
f9f2d97
Refactor HIP source collection in setup.py for improved readability
May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build_wheels_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
os: linux
with-cpu: enable
with-cuda: enable
with-rocm: disable
with-rocm: enable
with-xpu: enable
# Note: if free-threaded python is required add py3.13t here
python-versions: '["3.9"]'
Expand Down
21 changes: 11 additions & 10 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,16 +311,17 @@ def get_extensions():
glob.glob(os.path.join(extensions_cuda_dir, "**/*.cu"), recursive=True)
)

extensions_hip_dir = os.path.join(
extensions_dir, "cuda", "tensor_core_tiled_layout"
)
hip_sources = list(
glob.glob(os.path.join(extensions_hip_dir, "*.cu"), recursive=True)
)
extensions_hip_dir = os.path.join(extensions_dir, "cuda", "sparse_marlin")
hip_sources += list(
glob.glob(os.path.join(extensions_hip_dir, "*.cu"), recursive=True)
)
# Define HIP source directories
hip_source_dirs = [
os.path.join(extensions_dir, "cuda", "tensor_core_tiled_layout"),
# TODO: Add sparse_marlin back in once we have a ROCm build for it
# os.path.join(extensions_dir, "cuda", "sparse_marlin")
]

# Collect all HIP sources from the defined directories
hip_sources = []
for hip_dir in hip_source_dirs:
hip_sources.extend(glob.glob(os.path.join(hip_dir, "*.cu"), recursive=True))

# Collect CUDA source files if needed
if not IS_ROCM and use_cuda:
Expand Down
Loading