Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable distributed FSDP Tests #206

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

msaroufim
Copy link
Member

@msaroufim msaroufim commented May 2, 2024

We needed to update our dev requirements with an older version of pytest. See #190 for more context

This is the upstream issue with pytest pytest-dev/pytest#12273 thanks @clee2000

We needed to update our dev requirements with an older version of pytest. See #190 for more context
@msaroufim msaroufim requested a review from cpuhrsch May 2, 2024 02:38
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2024
@msaroufim msaroufim requested a review from weifengpy May 2, 2024 03:07
Copy link
Contributor

@weifengpy weifengpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch on pytest version. did not know this became an issue recently

@msaroufim msaroufim merged commit a4921d7 into msaroufim-patch-3 May 2, 2024
4 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-5 branch May 2, 2024 03:45
@msaroufim
Copy link
Member Author

argh I opened a pr against my own branch lemme make an new pr

@msaroufim msaroufim mentioned this pull request May 2, 2024
@weifengpy
Copy link
Contributor

argh I opened a pr against my own branch lemme make an new pr

i am pretending not seeing this msg

yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* fix device int8 quant

* fix duplicate device on linear int8

* typo

* typo (missed comma made it a tuple)

* missing fqn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants