Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FQ mask in 8da4w QAT #199

Merged
merged 4 commits into from
May 3, 2024
Merged

Fix FQ mask in 8da4w QAT #199

merged 4 commits into from
May 3, 2024

Conversation

andrewor14
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2024
@andrewor14 andrewor14 requested a review from jerryzh168 May 1, 2024 20:52
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we test this with some manual data

@andrewor14
Copy link
Contributor Author

should we test this with some manual data

Yeah I'm testing it in my experiments. Not sure how to add a test for this though, seems tricky

@facebook-github-bot
Copy link

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@andrewor14 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@andrewor14 andrewor14 merged commit be30a7f into main May 3, 2024
16 of 17 checks passed
@andrewor14 andrewor14 deleted the 8da4w_qat_fix_fq branch May 3, 2024 20:59
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
yanbing-j pushed a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
* load quantized gguf

* add comments

* remove AOTI

* remove ubunut
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants