-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable compile with mxfp8 and mxfp4 cutlass gemm #1838
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1838
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 8f82ae7 with merge base 23c3162 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Does not work yet - bug in inductor? Test Plan: ``` pytest test/prototype/mx_formats -s -x -k test_linear_compile ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2e67d4783ed259ff432156ef7f16b6e850dce391 ghstack-comment-id: 2701081457 Pull Request resolved: #1838
Summary: Does not work yet - bug in inductor? Test Plan: ``` pytest test/prototype/mx_formats -s -x -k test_linear_compile ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9ea94a266e47e80760623fd6e3945e58a4ae02f8 ghstack-comment-id: 2701081457 Pull Request resolved: #1838
Summary: Does not work yet - bug in inductor? Test Plan: ``` pytest test/prototype/mx_formats -s -x -k test_linear_compile ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9ea94a266e47e80760623fd6e3945e58a4ae02f8 ghstack-comment-id: 2701081457 Pull Request resolved: #1838
Summary: Does not work yet - bug in inductor? Test Plan: ``` pytest test/prototype/mx_formats -s -x -k test_linear_compile ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: aac26d28a89c4bc676e9e6e480b95649ef6bde57 ghstack-comment-id: 2701081457 Pull Request resolved: #1838
Summary: Does not work yet - bug in inductor? Test Plan: ``` pytest test/prototype/mx_formats -s -x -k test_linear_compile ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 1e94dd3c894a3d975f37286bfb5f5cb142e7d30f ghstack-comment-id: 2701081457 Pull Request resolved: #1838
Summary: Does not work yet - bug in inductor? Test Plan: ``` pytest test/prototype/mx_formats -s -x -k test_linear_compile ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 521f541f6b3ec2ef3f01a7dd344198293902758b ghstack-comment-id: 2701081457 Pull Request resolved: #1838
lib.define("mx_fp4_bf16(Tensor a, Tensor b, Tensor a_scale, Tensor b_scale) -> Tensor") | ||
# Note: we need to add the `torch._C.Tag.needs_fixed_stride_order` tag in order for inductor | ||
# to honor the layout constraints for `b` in the two ops below. | ||
lib.define( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops I meant to add this before
Good catch
Summary:
Enables torch.compile e2e on MXLinear with the
mxfp8_cutlass
andmxfp4_cutlass
recipes. To do this, we need to add a tag on the op definitions to make inductor honor the col-major layout.Note that something else is broken with these ops and bias=True - leaving that for a future PR.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: