Implemented CUBLAS-style MXFP scale factor derivation, with test cases. #1835
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1835
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @frsun-nvda! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
| @@ -79,6 +79,49 @@ class ScaleCalculationMode(Enum): | |||
| FLOOR = auto() | |||
| CEIL = auto() | |||
| EVEN = auto() | |||
| CUBLAS_CEIL = auto() | |||
There was a problem hiding this comment.
nice! maybe we can also update the docblock on L77 to include this one?
There was a problem hiding this comment.
Done. Thanks for catching it.
|
Looks great |
|
Forwarded Frank the CLA procedure and hopefully we can get him through ASAP |
Implemented CUBLAS-style MXFP scale factor derivation, with test cases.
ScaleCalculationMode.CUBLAS_CEILnan,denormandnormalcases.