Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libOMP linking for experimental kernels #1828

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jack-Khuu
Copy link
Contributor

Remake of #1822


As mentioned in pytorch/torchchat#1493, we no longer need to explicitly link to OMP libs.

Copy link

pytorch-bot bot commented Mar 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1828

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 4da1fed with merge base ffb4350 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 4, 2025
@Jack-Khuu Jack-Khuu added the topic: bug fix Use this tag for PRs that fix bugs label Mar 4, 2025
@Jack-Khuu
Copy link
Contributor Author

Looks like just removing the omp link isn't enough. It can't find some omp related ops

Undefined symbols for architecture arm64:
        "___kmpc_fork_call", referenced from:
             ...
        "_omp_get_num_threads", referenced from:
            _.omp_outlined. in linear_8bit_act_xbit_weight.cpp.o
            _.omp_outlined..19 in linear_8bit_act_xbit_weight.cpp.o
            _.omp_outlined..20 in linear_8bit_act_xbit_weight.cpp.o
            _.omp_outlined..21 in linear_8bit_act_xbit_weight.cpp.o
            _.omp_outlined. in op_embedding_xbit_aten.cpp.o
            _.omp_outlined..189 in op_embedding_xbit_aten.cpp.o
            _.omp_outlined..192 in op_embedding_xbit_aten.cpp.o
            ...
        "_omp_get_thread_num", referenced from:

Note: This is unrelated (most likely) to the failures on main

Copy link
Contributor

@metascroy metascroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will work unless libomp.dylib is included in TORCH_LIBRARIES. CI is failing as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants