Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix USE_CPP=0 during local build #1812

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix USE_CPP=0 during local build #1812

wants to merge 1 commit into from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Mar 3, 2025

Summary:

Looks like this env var no longer matches its original intent (Python-only build)
as various other c++ extensions were added, fixing.

Test Plan:

with-proxy USE_CPP=0 pip install -e .

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 3, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Mar 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1812

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit f59eec9 with merge base 7963f9c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vkuzo added a commit that referenced this pull request Mar 3, 2025
Summary:

Looks like this env var no longer matches its original intent (Python-only build)
as various other c++ extensions were added, fixing.

Test Plan:

```
with-proxy USE_CPP=0 pip install -e .
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a231a6eca33e85d140578c99f10da3a15c60c481
ghstack-comment-id: 2694959518
Pull Request resolved: #1812
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 3, 2025
@vkuzo vkuzo added the topic: bug fix Use this tag for PRs that fix bugs label Mar 3, 2025
@vkuzo
Copy link
Contributor Author

vkuzo commented Mar 3, 2025

CI is failing, needs some work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: bug fix Use this tag for PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants