Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix replace_linear_8da4w missing arg #151

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix replace_linear_8da4w missing arg #151

merged 1 commit into from
Apr 19, 2024

Conversation

andrewor14
Copy link
Contributor

No description provided.

@andrewor14 andrewor14 requested a review from jerryzh168 April 19, 2024 22:41
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2024
jerryzh168
jerryzh168 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a test

@jerryzh168
Copy link
Contributor

merging first so it can be synced in fbcode

@jerryzh168 jerryzh168 merged commit 3124382 into main Apr 19, 2024
11 checks passed
@jerryzh168 jerryzh168 deleted the fix-replace-8da4w branch April 19, 2024 23:04
@andrewor14 andrewor14 mentioned this pull request Apr 22, 2024
Merged
dbyoung18 pushed a commit to dbyoung18/ao that referenced this pull request Jul 31, 2024
@andrewor14
Fix replace_linear_8da4w missing arg (pytorch#151)
28332a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewor14 @jerryzh168 @facebook-github-bot