[cleanup][1/x] make hp_tensor_to_float8_dynamic only work with hp inputs #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1458
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fb3b255 with merge base eab345c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Dec 23, 2024
Summary: `hp_tensor_to_float8_dynamic` should only work with high precision inputs, logic which checks for the input being already in float8 up to the callsites to make it more explicit and easier to follow. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 5aa5aaf6e776fe9bda230cebd0224404e0584372 ghstack-comment-id: 2560319845 Pull Request resolved: #1458
facebook-github-bot
added
the
CLA Signed
vkuzo
added
the
topic: not user facing
vkuzo
added a commit
that referenced
this pull request
Dec 23, 2024
Summary: `hp_tensor_to_float8_dynamic` should only work with high precision inputs, logic which checks for the input being already in float8 up to the callsites to make it more explicit and easier to follow. Test Plan: CI Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: bb4da6071929c65520ed03ea007ece8ddacc052a ghstack-comment-id: 2560319845 Pull Request resolved: #1458
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
hp_tensor_to_float8_dynamicshould only work with high precisioninputs, logic which checks for the input being already in float8 up
to the callsites to make it more explicit and easier to follow.
Test Plan: CI
Reviewers:
Subscribers:
Tasks:
Tags: