Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hardware check conditions #1356

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update hardware check conditions #1356

wants to merge 5 commits into from

Conversation

jainapurva
Copy link
Contributor

@jainapurva jainapurva commented Nov 27, 2024

Replace cuda architecture checks with the check function from torchao/utils:

  • is_cuda_8_9 -> is_sm_at_least_89
  • is_cuda_9_0 -> is_sm_at_least_90

Copy link

pytorch-bot bot commented Nov 27, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1356

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f292646 with merge base ed76e9c (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2024
@jainapurva jainapurva added topic: not user facing Use this tag if you don't want this PR to show up in release notes topic: for developers Use this tag if this PR is mainly developer facing labels Nov 27, 2024
@jainapurva jainapurva marked this pull request as ready for review November 28, 2024 00:12
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: for developers Use this tag if this PR is mainly developer facing topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants