-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SAM AMG README with more descriptive install instructions #1337
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1337
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 3dcb54f with merge base ed76e9c (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
python setup.py develop | ||
|
||
# On your mark, get set... | ||
cd examples/sam2_amg_server/ | ||
``` | ||
|
||
Download `sam2.1_hiera_large.pt` from https://github.com/facebookresearch/sam2?tab=readme-ov-file#download-checkpoints and put it into `~/checkpoints/sam2` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The download part I guess doesn't apply anymore now that the user can get this via the model type argument.
Looks good, let me know once you got a chance to give this another commit or two and then we can merge. |
@@ -2,18 +2,18 @@ | |||
|
|||
# Model | |||
model: | |||
_target_: sam2.modeling.sam2_base.SAM2Base | |||
_target_: torchao._models.sam2.modeling.sam2_base.SAM2Base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, these are the sam2 configs. There's sam2 and then there's sam2.1. I had to switched to sam2.1, but maybe sam2 is still useful? I updated the sam2.1 configs in b2e42ff#diff-12caf984b30e7028df7fb867a984c5ccad3fde0a0783df2af26db9cef860fbe5 , but in any case it doesn't hurt to have sam2 support as well.
@cpuhrsch
Installing was not so obvious, so this should help others trying to test and contribute.
There's some extra commits from amending, I'm still kinda garbage at git