Cutlass Qtile Size shrunk to 64 #5072
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@Aya-ZIbra has exported this pull request. If you are a Meta employee, you can view the originating Diff in D85155388. |
Summary: X-link: facebookresearch/FBGEMM#2078 Changing the QtileSize to 64. I see good improvement > 20 %.. For correctness this includes changing the TMEM atoms and introducing warp sync for row stats. Perf: ``` (Batch, SeqLenQ, SeqLenKV, MaxLenKV, HeadQ, HeadKV, HeadD) cutlass_blackwell_fmha_decode-gbps Improvment with Qtile = 64 (16, 1, 256, 256, 8, 1, 128) 238.2206209 1.31463193 (16, 1, 512, 512, 8, 1, 128) 410.8838061 1.315872068 (16, 1, 1024, 1024, 8, 1, 128) 660.5696208 1.335567769 (16, 1, 2048, 2048, 8, 1, 128) 916.5460174 1.310093116 (16, 1, 4096, 4096, 8, 1, 128) 1133.690174 1.258896694 (16, 1, 8192, 8192, 8, 1, 128) 1271.341515 1.229311967 (32, 1, 256, 256, 8, 1, 128) 468.9034945 1.295635241 (32, 1, 512, 512, 8, 1, 128) 799.2689835 1.280831124 (32, 1, 1024, 1024, 8, 1, 128) 1285.452285 1.293538886 (32, 1, 2048, 2048, 8, 1, 128) 1797.074701 1.269787171 (32, 1, 4096, 4096, 8, 1, 128) 2210.946865 1.229703361 (32, 1, 8192, 8192, 8, 1, 128) 2498.665399 1.212166122 (64, 1, 256, 256, 8, 1, 128) 893.9747894 1.302172409 (64, 1, 512, 512, 8, 1, 128) 1493.150844 1.274679551 (64, 1, 1024, 1024, 8, 1, 128) 2309.825211 1.220419935 (64, 1, 2048, 2048, 8, 1, 128) 3012.271892 1.159444905 (64, 1, 4096, 4096, 8, 1, 128) 3552.001019 1.089389445 (64, 1, 8192, 8192, 8, 1, 128) 4348.016208 1.131298153 (128, 1, 256, 256, 8, 1, 128) 1549.388365 1.233405251 (128, 1, 512, 512, 8, 1, 128) 2480.52007 1.210676964 (128, 1, 1024, 1024, 8, 1, 128) 3360.125922 1.145674899 (128, 1, 2048, 2048, 8, 1, 128) 4103.461192 1.093136854 (128, 1, 4096, 4096, 8, 1, 128) 4783.429328 1.095583284 ``` Reviewed By: jianyuh, v0i0 Differential Revision: D85155388
Aya-ZIbra
force-pushed
the
export-D85155388
branch
from
ce0508e to
41a878c
Compare
|
This pull request has been merged in 9ec0d72. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/2078
Changing the QtileSize to 64. I see good improvement > 20 %..
For correctness this includes changing the TMEM atoms and introducing warp sync for row stats.
Perf:
Reviewed By: jianyuh, v0i0
Differential Revision: D85155388