update hipify_torch submodule for version 2#4028
Closed
jeffdaily wants to merge 5 commits intopytorch:mainfrom
Closed
update hipify_torch submodule for version 2#4028jeffdaily wants to merge 5 commits intopytorch:mainfrom
jeffdaily wants to merge 5 commits intopytorch:mainfrom
Conversation
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
atalman
approved these changes
May 7, 2025
q10
approved these changes
May 7, 2025
Contributor
q10
left a comment
q10
left a comment
There was a problem hiding this comment.
LGTM, as the ROCm builds appear to have successfully completed
Contributor
|
@q10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
pytorch-bot bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 6, 2026
Summary: Reland of #137157. Needs pytorch/FBGEMM#4028 to be merged first to keep FBGEMM functional. - Remove all "MasqueradingAsCUDA" files and classes. - Do not rename "CUDA" classes to "HIP". cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd jerrymannil xinyazhang albanD voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben dllehr-amd chenyang78 Pull Request resolved: #151845 Reviewed By: ZainRizvi, q10, Camyll Differential Revision: D74538323 Pulled By: atalman
pytorch-bot bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jan 8, 2026
Summary: Reland of #137157. Needs pytorch/FBGEMM#4028 to be merged first to keep FBGEMM functional. - Remove all "MasqueradingAsCUDA" files and classes. - Do not rename "CUDA" classes to "HIP". cc H-Huang awgu wanchaol fegin fduwjj wz337 wconstab d4l3k pragupta msaroufim dcci sunway513 jithunnair-amd pruthvistony ROCmSupport jataylo hongxiayang naromero77amd jerrymannil xinyazhang albanD voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben dllehr-amd chenyang78 Pull Request resolved: #151845 Reviewed By: ZainRizvi, q10, Camyll Differential Revision: D74538323 Pulled By: atalman
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the hipify_torch submodule to conditionally use version 2 of the hipify mappings.