Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROCm runner #1193
Add ROCm runner #1193
Changes from 94 commits
59267a9
a223936
4610075
a506c52
f596bde
0cfb792
f13af44
25e5b71
dcbe19f
fda048e
00abba1
cf307b6
2d66ea8
958679b
e642a48
d0d294a
146f2df
eb0cf36
0c86f2b
6e7f13e
edd3306
9a45f4a
309a3a1
358eaf5
3a915a8
40928ba
69abf78
5c0096e
bfac874
1cf7e84
5b33287
2c514c5
0d5a012
ae14a47
1718605
bc902a3
0d95948
9a5a33b
6490dbc
77627ae
18b48e9
99a70e1
fed56ff
4b39a70
785afb8
bbd0ad1
9db83d8
eabd0a8
2038008
0202078
9cf8856
b885322
0e3dfdb
1f926e9
adefcc0
b96bd9a
3a1c2a3
f664267
d37293d
a986aec
2cc3656
b9ed7da
d4ebb6d
6552b13
cc8a0c2
3d714f9
a2998a6
6c2daa4
528c0aa
ae1a87f
21888fc
c5b158d
888550e
6103266
51f90ec
b5d9d4f
213667a
12dec21
c74102f
a639c59
d5e2685
a13b45e
4aad1e9
1993520
4e86fc9
bd39c03
a6e2458
85ac1e8
6c5ccc7
dc7d7ca
14f2f41
1fcaff5
b73c3a9
0c4b962
f7a0c68
54da556
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was raised by other FBGEMM developers: would you mind running the following tests too?
See this for a complete list: https://github.com/pytorch/FBGEMM/tree/main/fbgemm_gpu/test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shintaro-iwasaki , I'll enable these tests.
Another question, is it okay to open tracking issues in this repo that tack the ROCm skipped unit tests, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might not fully understand your question, but please create issues to keep track of skipped unit tests at this pytorch/fbgemm repository. Unlike PyTorch, we cannot skip tests by GitHub issues, though.