Set SanitizedResponse content to bytes instead of string
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `content` property of a `Response` object is expected to always be bytes (the `text` property should be a string). This change fixes an issue where consumers of the library that were returned a `SanitizedResponse` object could fail because they expected the `content` attribute of it to be bytes instead of a string. Signed-off-by: Carey Metcalfe <[email protected]>
jborean93
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
contentproperty of aResponseobject is expected to always be bytes (thetextproperty should be a string).This change fixes an issue where consumers of the library that were returned a
SanitizedResponseobject could fail because they expected thecontentattribute of it to be bytes instead of a string.