-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Doc from PEP 727: https://peps.python.org/pep-0727/ #277
Conversation
Sorry for the lint errors. 🤦 After the first one, I ran the command locally that exposed the error in tests but I didn't realize there was a different one to expose the error in the source. I hope I got them all now. 😅 |
BTW, if you want and/or is easier, feel free to discard this PR and make a new one, or take over and commit on top, etc. It's all good. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also be documented in the changelog and the documentation page. I'll push some changes in a moment.
FYI I pushed documentation, a few more dunder methods, and more tests. (I don't know why people like pickling typing objects but they do, so let's test that it works.) |
though not as much as people like making weakrefs to typing objects, apparently ;) |
Co-authored-by: Alex Waygood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! (Some concerns about the name of the doc section, but that's something we can always change later.)
Thanks @JelleZijlstra! I renamed the section to |
We haven't discussed this anywhere yet, but I just realizing (right after you merged this one 🤦), b now that there's only one class The main argument I can think of for that is that it's shorter and would be somewhat similar to an enum where the actual value is stored in an attribute |
I don't feel too strongly. I think the precise name is nice to make it clear what you are working with (e.g., you can grep for (Just for backward compatibility in typing-extensions, if we do release with |
Thank you for the quick feedback! Perfect. 🤓🚀 |
Add doc and DocInfo from PEP 727: https://peps.python.org/pep-0727/
I'm not too familiar with the process in this codebase and what else would be expected, not sure if I'm missing something else, or if there's anything else I should test, order things in a different way, etc. 🤓