Skip to content

Commit

Permalink
Bump version to 3.7.4.2
Browse files Browse the repository at this point in the history
  • Loading branch information
@gvanrossum
gvanrossum committed Jul 9, 2020
1 parent 0b0e248 commit c850161
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions setup.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
import sys
from setuptools import setup

if sys.version_info < (2, 7, 0) or (3, 0, 0) <= sys.version_info < (3, 4, 0):
sys.stderr.write('ERROR: You need Python 2.7 or 3.4+ '
if sys.version_info[:2] not in ((2, 7), (3, 4)):

This comment has been minimized.

Sign in to view

Copy link
@dvvolynkin

dvvolynkin Jul 10, 2020 •
edited
Loading

Is this changement for a patch-version?
I guess it can break something

This comment has been minimized.

Sign in to view

Copy link
@gdippolito

gdippolito Jul 10, 2020

Indeed it broke couchbase python client.

This comment has been minimized.

Sign in to view

Copy link
@gvanrossum

gvanrossum Jul 10, 2020

Author Member

@gdippolito

Indeed it broke couchbase python client.

Can you provide details? Link to an issue?

This comment has been minimized.

Sign in to view

Copy link
@gvanrossum

gvanrossum Jul 10, 2020

Author Member

@dvvolynkin

For the reason see #721.

This comment has been minimized.

Sign in to view

Copy link
@gdippolito

gdippolito Jul 10, 2020 •
edited
Loading

Can you provide details? Link to an issue?

I have tried to access their JIRA board to open an issue but I'm still waiting for it.

In short. this succeed (it will complain about a library not being present but it is after typing):

docker run ubuntu:18.04 /bin/bash -c "apt update && apt install python3-pip -y && pip3 install typing==3.7.4.1 && pip3 install couchbase==2.5.12"

This fail:

docker run ubuntu:18.04 /bin/bash -c "apt update && apt install python3-pip -y && pip3 install couchbase==2.5.12

This comment has been minimized.

Sign in to view

Copy link
@gvanrossum

gvanrossum via email Jul 10, 2020

Author Member

This comment has been minimized.

Sign in to view

Copy link
@hermanschaaf

hermanschaaf Jul 10, 2020

@gvanrossum I was able to reproduce the issue with the couchbase library described by @gdippolito on Python 3.6.9, but not Python 3.7.5. That's because the couchbase 2.5.12 library only requires typing for versions below 3.7: https://github.com/couchbase/couchbase-python-client/blob/d08d2ca1ae8dbcb1a667ce922b579eac227402d9/setup.py#L196-L197

This comment has been minimized.

Sign in to view

Copy link
@vkuzmin-uber

vkuzmin-uber Jul 10, 2020

I created Issue #739
sys.stderr.write('ERROR: You need Python 2.7 or 3.4 '
'to install the typing package.\n')
exit(1)

version = '3.7.4.1'
version = '3.7.4.2'
description = 'Type Hints for Python'
long_description = '''\
Typing -- Type Hints for Python
Expand Down

1 comment on commit c850161

@gvanrossum
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is wrong — typing is in the stdlib for 3.5 and 3.6 too, and pip install doesn’t override stdlib modules.

Please sign in to comment.