invoke: Update Context.cd() to accept a pathlib.Path or a string

[rouge8]

This matches the (unreleased) type hints for invoke: https://github.com/pyinvoke/invoke/blob/e95631215fac9ef454f064e2a701f8fce351752d/invoke/context.py#L346

[AlexWaygood]

It looks to me like the runtime implementation is incorrect. They're calling str() on the path argument here, rather than os.fspath. That means that the function will work with str and pathlib.Path objects, but it won't actually work with arbitrary os.PathLike objects, even if that's what the type hints in the upstream source code say. So maybe the type hint should actually be str | pathlib.Path rather than StrPath.

(Upstream should probably update their implementation so that it calls os.fspath() rather than str() on the path parameter. Then the implementation would match the type hint that they've provided.)

[rouge8]

It looks to me like the runtime implementation is incorrect. They're calling str() on the path argument here, rather than os.fspath. That means that the function will work with str and pathlib.Path objects, but it won't actually work with arbitrary os.PathLike objects, even if that's what the type hints in the upstream source code say. So maybe the type hint should actually be str | pathlib.Path rather than StrPath.

(Upstream should probably update their implementation so that it calls os.fspath() rather than str() on the path parameter. Then the implementation would match the type hint that they've provided.)

Ooh, good catch. I'll open a PR upstream to fix that.

[AlexWaygood]

Thanks!

[github-actions]

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉