Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never use more than one Literal per union #6984

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Never use more than one Literal per union #6984

merged 1 commit into from
Jan 20, 2022

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood mentioned this pull request Jan 20, 2022
Merged
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Akuli
Akuli approved these changes Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The occurrences in tkinter were generated by a script I wrote. I wrote the script before I learned that you can put multiple strings inside a single Literal, and modified the script afterwards, but apparently missed something while editing it :)

@Akuli Akuli merged commit 76af728 into python:master Jan 20, 2022
@AlexWaygood AlexWaygood deleted the unions branch January 20, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @JelleZijlstra @Akuli