remove "= ..." from top-level values #6930
Conversation
Unblocks turning on Y092; see PyCQA/flake8-pyi#86
|
OK, now normal flake8 thinks all of these names are undefined :). I'll back out the changes to names used elsewhere in the stub for now, and leave only the changes to the constants. We could do some smarter things:
|
This comment has been minimized.
This comment has been minimized.
|
Simpler solution: just add Y092 to the list of error codes ignored in Line 28 in 425ba77 |
|
It's not just typing, but also something in pkg_resources that could easily appear in other stubs. I feel like the benefit of this change is low enough that it's not worth the risk of confusing a new contributor who runs into a false positive, so I'm not planning to build anything more complicated here. |
Yes, good point. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Disabled-by-default error codes are problematic; see #75. Y092 finds a fairly harmless error and has significant false positives (python/typeshed#6930). I'm removing it so we can get rid of disabled-by-default errors and simplify our setup.
Disabled-by-default error codes are problematic; see #75. Y092 finds a fairly harmless error and has significant false positives (python/typeshed#6930). I'm removing it so we can get rid of disabled-by-default errors and simplify our setup.
3 participants
Unblocks turning on Y092; see PyCQA/flake8-pyi#86