[xmltodict] stub improvements and update to 1.0 #14695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

srittau merged 17 commits into python:main from tapple-cisco:xmltodict

Sep 19, 2025

Contributor

tapple-cisco commented Sep 11, 2025 •

edited

Loading

Closes: [stubsabot] Bump xmltodict to 1.0.* #14710
Closes: [xmltodict] Update to 1.0.* #14712
Document private class _DictSAXHandler
Add default values
Reveal kwargs

tapple-cisco added 2 commits

September 11, 2025 14:53


          improve unparse

89d4b1e


          replaced a few Any with Incomplete

b9948ca

This comment has been minimized.

Sign in to view

tapple-cisco and others added 2 commits

September 11, 2025 13:16


          complete all incomplete types

5b121d5


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d5dd82f

This comment has been minimized.

Sign in to view


          pre-commit

8e05ccf

brianschubert reviewed

View reviewed changes

stubs/xmltodict/xmltodict.pyi Show resolved Hide resolved


          mypy 3.9

3c550cd

tapple-cisco marked this pull request as ready for review

September 11, 2025 20:57

This comment has been minimized.

Sign in to view


          Note that the bug I mentioned just got closed today

6fc60da

Contributor Author

tapple-cisco commented Sep 12, 2025

Marking this as draft as it looks like upstream is about to make a new release that changes some types

tapple-cisco marked this pull request as draft

September 12, 2025 14:31

This comment has been minimized.

Sign in to view


          unreleased force_cdata type change

53dbb53

martinblech/xmltodict@512f682

This comment has been minimized.

Sign in to view

This was referenced Sep 12, 2025

Type Annotations martinblech/xmltodict#285

Closed

doc: mention types-xmltodict package in README martinblech/xmltodict#380

Merged


          Merge from donBarbos:bump-xmltodict-1.0: [xmltodict] Update to 1.0.*

ea81718

- Closes: python#14710
- Add default values
- Reveal kwargs
- Add to stricter pyright exclude list

tapple-cisco marked this pull request as ready for review

September 15, 2025 13:37

tapple-cisco mentioned this pull request

[xmltodict] Update to 1.0.* #14712

Merged

tapple-cisco changed the title ~~xmltodict stub improvements~~ xmltodict stub improvements and bump to 1.0

This comment has been minimized.

Sign in to view

Contributor Author

tapple-cisco commented Sep 15, 2025

Ready for review as xmltodict 1.0 is released and I included it with a merge from @donbarbos

tapple-cisco changed the title ~~xmltodict stub improvements and bump to 1.0~~ [xmltodict] stub improvements and update to 1.0


          remove from pyright stricter exclude list

412d36f

tapple-cisco commented

View reviewed changes

pyrightconfig.stricter.json Show resolved Hide resolved

This comment has been minimized.

Sign in to view

srittau requested changes

View reviewed changes

Collaborator

srittau left a comment

Thanks! (I'm fine with including the internal class as well.) One question and two remarks below.

stubs/xmltodict/xmltodict.pyi Outdated Show resolved Hide resolved

stubs/xmltodict/xmltodict.pyi Show resolved Hide resolved

stubs/xmltodict/xmltodict.pyi Show resolved Hide resolved


          address srittau's comments

4efc9bb

tapple-cisco requested a review from srittau

September 18, 2025 19:09

This comment has been minimized.

Sign in to view


          updates for 1.0.2

7f54a8f

This comment has been minimized.

Sign in to view

srittau approved these changes

View reviewed changes

srittau and others added 2 commits

September 19, 2025 11:47


          Merge branch 'main' into xmltodict

17787e4


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d18fff7

This comment has been minimized.

Sign in to view

Collaborator

srittau commented Sep 19, 2025

@tapple-cisco I've merged @donbarbos's PR first to have the correct author information in the repository. Unfortunately, it seems that xmltodict 1.0.1 removed the __author__, __version__, and __license__ fields. Could you remove them and update the version field to ~= 1.0.1?

tapple-cisco added 2 commits

September 19, 2025 05:56


          updates for 1.0.1

78d836a


          updates for 1.0.1

c11a3ef

Contributor Author

tapple-cisco commented Sep 19, 2025

@tapple-cisco I've merged @donbarbos's PR first to have the correct author information in the repository. Unfortunately, it seems that xmltodict 1.0.1 removed the __author__, __version__, and __license__ fields. Could you remove them and update the version field to ~= 1.0.1?

I did that before your merge 7f54a8f and I repeated it: 78d836a c11a3ef

This comment has been minimized.

Sign in to view

srittau reviewed

View reviewed changes

stubs/xmltodict/METADATA.toml Outdated Show resolved Hide resolved


          Apply srittau suggestion

d50bb0b

Co-authored-by: Sebastian Rittau <[email protected]>

Contributor

github-actions bot commented Sep 19, 2025

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau approved these changes

View reviewed changes

srittau merged commit 15bc02e into python:main

48 checks passed

AlexWaygood mentioned this pull request

Use stricter pyright settings for xmltodict #14763

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet