Skip to content

[xmltodict] stub improvements and update to 1.0 #14695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 19, 2025
Merged

[xmltodict] stub improvements and update to 1.0 #14695

merged 17 commits into from
Sep 19, 2025
+75 −28

Conversation

tapple-cisco
Copy link
Contributor

@tapple-cisco tapple-cisco commented Sep 11, 2025 •
edited
Loading

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
brianschubert
brianschubert reviewed Sep 11, 2025
View reviewed changes
@tapple-cisco tapple-cisco marked this pull request as ready for review September 11, 2025 20:57
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@tapple-cisco
Copy link
Contributor Author

Marking this as draft as it looks like upstream is about to make a new release that changes some types

@tapple-cisco tapple-cisco marked this pull request as draft September 12, 2025 14:31
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
This was referenced Sep 12, 2025
Closed
Merged
@donBarbos @tapple-cisco
Merge from donBarbos:bump-xmltodict-1.0: [xmltodict] Update to 1.0.*
ea81718 
- Closes: python#14710
- Add default values
- Reveal kwargs
- Add to stricter pyright exclude list
@tapple-cisco tapple-cisco marked this pull request as ready for review September 15, 2025 13:37
@tapple-cisco tapple-cisco mentioned this pull request Sep 15, 2025
Merged
@tapple-cisco tapple-cisco changed the title xmltodict stub improvements xmltodict stub improvements and bump to 1.0 Sep 15, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@tapple-cisco
Copy link
Contributor Author

Ready for review as xmltodict 1.0 is released and I included it with a merge from @donBarbos

@tapple-cisco tapple-cisco changed the title xmltodict stub improvements and bump to 1.0 [xmltodict] stub improvements and update to 1.0 Sep 15, 2025
tapple-cisco
tapple-cisco commented Sep 15, 2025
View reviewed changes
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
srittau
srittau requested changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (I'm fine with including the internal class as well.) One question and two remarks below.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@srittau
Copy link
Collaborator

srittau commented Sep 19, 2025

@tapple-cisco I've merged @donBarbos's PR first to have the correct author information in the repository. Unfortunately, it seems that xmltodict 1.0.1 removed the __author__, __version__, and __license__ fields. Could you remove them and update the version field to ~= 1.0.1?

@tapple-cisco
Copy link
Contributor Author

@tapple-cisco I've merged @donBarbos's PR first to have the correct author information in the repository. Unfortunately, it seems that xmltodict 1.0.1 removed the __author__, __version__, and __license__ fields. Could you remove them and update the version field to ~= 1.0.1?

I did that before your merge 7f54a8f and I repeated it: 78d836a c11a3ef

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
srittau
srittau reviewed Sep 19, 2025
View reviewed changes
@tapple-cisco @srittau
Apply srittau suggestion
d50bb0b 
Co-authored-by: Sebastian Rittau <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 15bc02e into python:main Sep 19, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianschubert brianschubert brianschubert left review comments

@srittau srittau srittau approved these changes

+1 more reviewer

@donBarbos donBarbos donBarbos left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tapple-cisco @srittau @brianschubert @donBarbos