Skip to content

Add @disjoint_base to builtins.tuple #14683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2025
Merged

Add @disjoint_base to builtins.tuple #14683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d0a504
Add @disjoint_base to builtins.tuple
JelleZijlstra Sep 6, 2025
ad645d7
allowlist
JelleZijlstra Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion stdlib/@tests/stubtest_allowlists/common.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ importlib.abc.PathEntryFinder.find_spec # Not defined on the actual class, but
tkinter.simpledialog.[A-Z_]+
tkinter.simpledialog.TclVersion
tkinter.simpledialog.TkVersion
builtins.tuple # should have @disjoint_base but hits pyright issue
tarfile.TarInfo.__slots__ # it's a big dictionary at runtime and the dictionary values are a bit long


Expand Down
3 changes: 1 addition & 2 deletions stdlib/builtins.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,8 +1021,7 @@ class slice(Generic[_StartT_co, _StopT_co, _StepT_co]):

def indices(self, len: SupportsIndex, /) -> tuple[int, int, int]: ...

# Making this a disjoint_base upsets pyright
# @disjoint_base
@disjoint_base
class tuple(Sequence[_T_co]):
def __new__(cls, iterable: Iterable[_T_co] = ..., /) -> Self: ...
def __len__(self) -> int: ...
Expand Down
Loading