Skip to content

Fix base class compatibility for IntFlag in Python 3.11+ to resolve inverted type issue #13854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Fix base class compatibility for IntFlag in Python 3.11+ to resolve inverted type issue #13854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
586d5ee
Fix base class compatibility for IntFlag in Python 3.11+ to resolve i…
vidhyavijayan3 Apr 19, 2025
40986bc
Addressed the review comments
vidhyavijayan3 Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stdlib/enum.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ if sys.version_info >= (3, 11):
def __or__(self, other: int) -> Self: ...
def __and__(self, other: int) -> Self: ...
def __xor__(self, other: int) -> Self: ...
def __invert__(self) -> IntFlag: ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __invert__(self) -> IntFlag: ...
def __invert__(self) -> Self: ...

__ror__ = __or__
__rand__ = __and__
__rxor__ = __xor__
Expand All @@ -309,6 +310,7 @@ else:
def __or__(self, other: int) -> Self: ...
def __and__(self, other: int) -> Self: ...
def __xor__(self, other: int) -> Self: ...
def __invert__(self) -> IntFlag: ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def __invert__(self) -> IntFlag: ...
def __invert__(self) -> Self: ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! @brianschubert I've made the changes you recommended.

__ror__ = __or__
__rand__ = __and__
__rxor__ = __xor__
Expand Down