fix pyscreeze.locateCenterOnScreen #13852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
give parameter minSearchTime a default value of 0 in function pyscreeze.locateCenterOnScreen.
This comment has been minimized.
This comment has been minimized.
Avasam
requested changes
Apr 20, 2025
brasswood
commented
Apr 20, 2025
Contributor
Author
brasswood
left a comment
brasswood
left a comment
There was a problem hiding this comment.
Thanks for that catch
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision)
- torchvision/utils.py:271: error: Unused "type: ignore" comment [unused-ignore]
|
Avasam
approved these changes
Apr 20, 2025
mmingyu
pushed a commit
to mmingyu/typeshed
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give parameter
minSearchTimea default value of 0 in functionpyscreeze.locateCenterOnScreen. This should be okay because in the actual library,locateCenterOnScreenjust delegates all of its parameters tolocateOnScreen, and the type definition here forlocateOnScreengivesminSearchTimea default value of 0.Fixes #13851