Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy_test: Exclude sub-modules not in current Py version #12352

Merged
merged 6 commits into from
Jul 16, 2024
Merged

mypy_test: Exclude sub-modules not in current Py version #12352

merged 6 commits into from
Jul 16, 2024

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented Jul 16, 2024

No description provided.

@srittau srittau marked this pull request as draft July 16, 2024 10:42
@srittau
Copy link
Collaborator Author

srittau commented Jul 16, 2024

Depends on #12351.

@AlexWaygood
Copy link
Member

Note that pyright is also failing on #12298 for the same reasons as mypy_test.py. Fixing that might be significantly trickier since we currently run pyright via a GitHub action rather than via a Python script.

@srittau srittau marked this pull request as ready for review July 16, 2024 10:59
@srittau srittau merged commit cc40120 into python:main Jul 16, 2024
67 checks passed
@srittau srittau deleted the mypy-test-versions branch July 16, 2024 14:04
max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Jul 23, 2024
@srittau @max-muoto
mypy_test: Exclude sub-modules not in current Py version (python#12352)
94bbcd9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srittau @AlexWaygood @JelleZijlstra