Skip to content

5-ary izip #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 10 commits into from
Mar 21, 2017
Merged

5-ary izip #1042

Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
42f37c0
5-ary izip
gnoack Mar 20, 2017
536d192
Update itertools.pyi
gnoack Mar 20, 2017
8e0d38f
Update itertools.pyi
gnoack Mar 20, 2017
014a23a
Define _T5
gnoack Mar 20, 2017
62efd05
Add support for 6-ary izip and generic n-ary case
gnoack Mar 20, 2017
cd949ba
Fix fallback.
gnoack Mar 20, 2017
4152283
Update itertools.pyi
gnoack Mar 20, 2017
4e62b05
Update itertools.pyi
gnoack Mar 20, 2017
4149a26
Update itertools.pyi
gnoack Mar 20, 2017
b621b2f
Remove fallback again
gnoack Mar 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion stdlib/2/itertools.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ _T1 = TypeVar('_T1')
_T2 = TypeVar('_T2')
_T3 = TypeVar('_T3')
_T4 = TypeVar('_T4')
_T5 = TypeVar('_T5')

@overload
def imap(func: Callable[[_T1], _S], iter1: Iterable[_T1]) -> Iterator[_S]: ...
Expand All @@ -71,7 +72,13 @@ def izip(iter1: Iterable[_T1], iter2: Iterable[_T2],
@overload
def izip(iter1: Iterable[_T1], iter2: Iterable[_T2], iter3: Iterable[_T3],
iter4: Iterable[_T4]) -> Iterator[Tuple[_T1, _T2,
_T3, _T4]]: ... # TODO more than four iterables
_T3, _T4]]: ...
@overload
def izip(iter1: Iterable[_T1], iter2: Iterable[_T2], iter3: Iterable[_T3],
iter4: Iterable[_T4], iter5: Iterable[_T5]) -> Iterator[Tuple[_T1, _T2,
_T3, _T4, _T5]]: ...
# TODO more than five iterables
Copy link
Contributor

@matthiaskramm matthiaskramm Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the following:

def izip(*iter: Iterable) -> Iterator[tuple]

?

Copy link
Contributor

@matthiaskramm matthiaskramm Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see you already commented on that. Feel free to do the explicit version for as many arguments as you see fit, but the list of signatures should finish with the general case, even if it's less precise.

Copy link
Contributor Author

@gnoack gnoack Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, adding 6-ary variant and n-ary fallback.

Copy link
Contributor Author

@gnoack gnoack Mar 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the fallback again, that didn't work in Python3.5 (see the more recent Travis failures).


def izip_longest(*p: Iterable[Any],
fillvalue: Any = ...) -> Iterator[Any]: ...

Expand Down