fix: links are direct to asset

[JacobCoffee]

Description

• Fixes asset links on sponsor user page

Closes

• Closes: Bug: View provided assets button takes you to the full assets list #2577

funny

• code change: 30 minutes
• tests: 1.5 hours

[ewdurbin]

We're effectively displaying all the same information here now that was previously available in the users:view_provided_assets view.

Should we just replicate the template logic from

pythondotorg/templates/users/sponsorship_assets_view.html

Lines 21 to 32 in ccbc9e4

	{% for asset in provided_assets %}
	<p><b>{{ asset.sponsor_benefit }}</b> benefit provides you with {{ asset.label }}:</p>
	{% if asset.polymorphic_ctype.name == "Provided Text" %}
	<pre>{{ asset.value|urlize }}</pre>
	{% elif asset.polymorphic_ctype.name == "Provided File" %}
	<a href="{{ asset.value.url }}">View File</a>
	{% else %}
	{{ asset.value }}
	{% endif %}
	<small>{{ asset.help_text }}</small>
	<br><br>
	{% endfor %}

and remove the "Or you can also click here to view all the assets under the same page" part?

[ewdurbin]

Note only reason I bring up replicating the template logic is to restore the help text and context for each.

Compare

on the existing "view all" page with

On the new dashboard section.

[JacobCoffee]

It did add a chunk of text if that is a concern. Keeping the core dashboard leaner feels better imo but @loren-c may like the all-in-one approach :D

[JacobCoffee]

Current:

@ewdurbin Suggested:

As an aside I think this could use some rearranging or love because its very squished and would look better some other way

[JacobCoffee]

Something like

Seems one of my main issues comes from

pythondotorg/templates/users/base.html

Line 13 in 301bfe2

{% block content_attributes %}with-right-sidebar{% endblock %}

because we just leave a ton of empty space when there is no sidebar

[JacobCoffee]

or

[loren-c]

I do like the 'all in one' approach provided we can make it more manageable and not just a giant list, and I do like Jacob's second version.

Looking at the dashboard with all the information on one page, an ability to sort the required assets by due date or by incomplete/complete would be nice, but that seems like a whole other functionality and just a nice to have.

[JacobCoffee]

Changes in e53f422

Although I am not 100%, my checks into the various user views for the removal ofwith-right-sidebar have shown that everything just fills the empty space instead of wasting it. Have yet to find a page that uses it but I will continue to check.

How it looks ish (latest changes I removed excessive padding as you can see in image 1 but further images have it in screenshot.. has since been fixed)

Details

[JacobCoffee]

could maybe make this more fancy