Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update library/typing #691

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Update library/typing #691

merged 6 commits into from
Nov 6, 2023

Conversation

rockleona
Copy link
Collaborator

@rockleona rockleona commented Oct 31, 2023

有時間做一點點進度,免得被世人遺忘

Preview

image

image

image

image

image

image

library/typing.po Outdated Show resolved Hide resolved
@rockleona rockleona changed the title Update NewType Section Update library/typing Nov 1, 2023
@rockleona rockleona marked this pull request as ready for review November 1, 2023 06:26
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 1

library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review part 2
我覺得修完這邊就可以 merge 了,辛苦了!

library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
library/typing.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattwang44 mattwang44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE WORK!

@mattwang44 mattwang44 enabled auto-merge (squash) November 6, 2023 02:55
@mattwang44 mattwang44 merged commit 72726c2 into python:3.12 Nov 6, 2023
1 check passed
isabellechiu pushed a commit to isabellechiu/python-docs-zh-tw that referenced this pull request Dec 5, 2023
* Update NewType Section

* Finish translate this section

* Update with reviewer's suggestion

* Update Reviewer's Comment Part 2

* Update library/typing.po

---------

Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
beccalzh pushed a commit to beccalzh/python-docs-zh-tw that referenced this pull request Sep 4, 2024
* Update NewType Section

* Finish translate this section

* Update with reviewer's suggestion

* Update Reviewer's Comment Part 2

* Update library/typing.po

---------

Co-authored-by: Wei-Hsiang (Matt) Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants