-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a benchmark for the Azure CLI. #90
Open
ericsnowcurrently
wants to merge
13
commits into
python:main
Choose a base branch
from
ericsnowcurrently:add-bm-azure-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add a benchmark for the Azure CLI. #90
ericsnowcurrently
wants to merge
13
commits into
python:main
from
ericsnowcurrently:add-bm-azure-cli
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Hmm...
|
FYI, using azure-cli on 3.9+ is currently blocked: Azure/azure-cli#16611. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of CPython performance work that @gvanrossum and I are starting. We want to use pyperformance to run our benchmarks (and profiling, but that's a separate issue). As there isn't a mechanism to plug in custom benchmarks, I'm putting up this PR.
I suppose there's the question of whether this is an appropriate benchmark for the suite. I think so. It represents a workload, based on concrete usage patterns for a widely used CLI app, that does not seem to be covered by other benchmarks. Note that at the moment I'm cheating a little by running tests out of the azure-cli test suite. However, I expect the tests exercise the code in a very similar way to common usage of the actual application. If there are concerns about inclusion I'm fine with leaving it out.
We will be using this benchmark (and a few others we will probably add) extensively.
(Either way, it would still be nice to have a way to plug in custom benchmarks externally. See #89.)