Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dns): update boto pkg blocks with new onedir install method #538

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(dns): update boto pkg blocks with new onedir install method #538

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66e603e
fix(dns): update boto pkg blocks with new onedir install method
JacobCoffee Dec 17, 2024
4184bd6
chore: remove unused debs
JacobCoffee Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions salt/dns/init.sls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
boto-pkgs:
pkg.installed:
- pkgs:
- python3-boto
- python3-boto3
boto:
pip.installed:
JacobCoffee marked this conversation as resolved.
Show resolved Hide resolved
- pip_bin: /usr/bin/salt-pip

boto3:
pip.installed:
- pip_bin: /usr/bin/salt-pip

{% set public_ipv4 = salt["mine.get"]("*", "public_ipv4") %}

# We assume that a server will always have an IPv4 address.

# TODO: Update back to boto3_route53 when https://github.com/saltstack/salt/pull/60951 makes it into a release
# TODO(@JacobCoffee): Update back to boto3_route53
{% for server in public_ipv4 %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall why boto3 is preferred, but this is the diff that originally moved us back to just both: 4ebb9fd

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc from reading boto3 was the automagically generated thing from the AWS spec whereas boto was done by hand

{{ server }}-route53:
boto_route53.rr_present:
Expand Down
Loading