Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 677: Minor wording and formatting fixes. #2225

Merged
merged 1 commit into from
Jan 11, 2022
Merged

PEP 677: Minor wording and formatting fixes. #2225

merged 1 commit into from
Jan 11, 2022

Conversation

stroxler
Copy link
Contributor

We're getting ready for a final request for comments to python-dev,
so I did one more pass through the PEP to catch remaining readability
issues (I was especially looking for things easier to see on the actual
PEP page with formatting than the rst doc), e.g.:

  • found an incorrectly formatted hyperlink
  • reworded sentences that seemed ambiguous (e.g. ambiguous pronouns)
  • adjusted wording to better match the order of sections

@stroxler
PEP 677: Minor wording and formatting fixes.
a3869e2 
We're getting ready for a final request for comments to python-dev,
so I did one more pass through the PEP to catch remaining readability
issues (I was especially looking for things easier to see on the actual
PEP page with formatting than the rst doc):
- found an incorrectly formatted hyperlink
- changed some sentences with ambiguous pronouns
- broke up a couple of sentences that seemed too long
- tweaked a few places where the wording was okay but nonstandard
JelleZijlstra
JelleZijlstra approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this unless you want me to wait for Guido to take a look.

@AlexWaygood
Copy link
Member

It's unrelated to the changes proposed here, but with regards to the statistics cited in lines 126-130, it might be worth noting that typeshed has now completely eliminated its use of typing.List and typing.Tuple following the release of mypy 0.920.

@stroxler
Copy link
Contributor Author

@JelleZijlstra I think this should be okay to merge - nothing substantive, just readability

@gvanrossum gvanrossum merged commit 218e2cc into python:main Jan 11, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 13, 2022
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stroxler @AlexWaygood @JelleZijlstra @gvanrossum @the-knights-who-say-ni