Convert PEPs 261, 267, 325, 358, 361 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
reviewed
Feb 10, 2017
| ======== | ||
|
|
||
| Character | ||
| Used by itself, means the addressable units of a Python |
There was a problem hiding this comment.
How does this indented stuff look rendered? Should these be unindented and made into sub-sections?
There was a problem hiding this comment.
This becomes a definition list item: http://cpython-devguide.readthedocs.io/documenting.html?highlight=definition%20list#lists-and-quotes
But I can convert these into sub-headings too.
There was a problem hiding this comment.
That looks reasonable to me!
brettcannon
approved these changes
Feb 10, 2017
|
LGTM |
Mariatta
commented
Feb 10, 2017
pep-0261.txt
Outdated
| represented as a single Python character. It generates two | ||
| Python characters known as a "surrogate pair". Should this | ||
| be disallowed on future narrow Python builds? | ||
| Python currently allows \U literals that cannot be |
There was a problem hiding this comment.
Just noticed that the \U isn't rendered correctly 😅
Will make another commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation for #4