Restify PEP 303 #142
Merged
Restify PEP 303 #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep the file for conversion by restify script Add colon where necessary
Output from restify script
Some manual adjustments
berkerpeksag
requested changes
Nov 27, 2016
|
|
||
| The built-in ``divmod()`` function would be changed to accept multiple | ||
| divisors, changing its signature from ``divmod(dividend, divisor)`` to | ||
| divmod(dividend, \*divisors). The dividend is divided by the last |
There was a problem hiding this comment.
``divmod(dividend, *divisors)``
| check its second argument for being a sequence is deemed to be too | ||
| ugly to contemplate. And in the case where one *does* have a | ||
| sequence that is computed other-where, it is easy enough to write | ||
| divmod(x, \*divs) instead. |
| new implementation of the function builtin_divmod() in | ||
| Python/bltinmodule.c | ||
| Not finished yet, but it seems a rather straightforward | ||
| new implementation of the function builtin_divmod() in |
| Python/bltinmodule.c | ||
| Not finished yet, but it seems a rather straightforward | ||
| new implementation of the function builtin_divmod() in | ||
| Python/bltinmodule.c |
There was a problem hiding this comment.
``Python/bltinmodule.c``. (notice the missing full stop)
|
Thanks, @berkerpeksag :) I addressed your comments. |
Mariatta
commented
Nov 27, 2016
| that the target tuple is of the right length. Users from other | ||
| languages are more likely to understand the standard two argument | ||
| form without having to re-read the documentation. See python-dev | ||
| discussion on 17 June 2005. |
There was a problem hiding this comment.
Is this the correct discussion thread? https://mail.python.org/pipermail/python-dev/2005-June/054283.html
Should it be linked from here?
There was a problem hiding this comment.
Looks like it is, nice detective work :) Yes, it would be nice to add a link.
There was a problem hiding this comment.
Thanks :) I added the link to it.
berkerpeksag
approved these changes
Nov 28, 2016
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly converted via a script but there were manual adjustments :)
Let me know what you think about this.