Use some more dogfooding #7385
Merged
Use some more dogfooding #7385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I had a PR merged with pyflakes to fix the lint issues (PyCQA/pyflakes#455) but it hasn't been released yet I think |
Member
Author
|
@msullivan This is great! We can then remove |
Member
Author
|
I think this is quite uncontroversial, so I am going to merge this now. |
Michael0x2a
pushed a commit
to Michael0x2a/mypy
that referenced
this pull request
Aug 25, 2019
This PR enables `--strict-equality` and `--show-error-codes` for self-check, and adds error codes in some `# type: ignore`s. So far this revealed two issues: * Both PyCharm and flake8 get crazy about error codes, generating many false positives * Error codes in `# type: ignore`s don't always work, see python#7384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
--strict-equalityand--show-error-codesfor self-check, and adds error codes in some# type: ignores. So far this revealed two issues:# type: ignores don't always work, see Error codes in # type: ignore don't suppress related notes #7384