Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion mypy/semanal.py
Original file line number Diff line number Diff line change
Expand Up @@ -4014,12 +4014,13 @@ def analyze_alias(
python_3_12_type_alias=python_3_12_type_alias,
)

# There can be only one variadic variable at most, the error is reported elsewhere.
# Check for multiple TypeVarTuples in type alias definition
new_tvar_defs = []
variadic = False
for td in tvar_defs:
if isinstance(td, TypeVarTupleType):
if variadic:
self.fail("Can only use one TypeVarTuple in a type alias", rvalue)
continue
variadic = True
new_tvar_defs.append(td)
Expand Down
23 changes: 23 additions & 0 deletions test-data/unit/check-python312.test
Original file line number Diff line number Diff line change
Expand Up @@ -2237,3 +2237,26 @@ class D[*Ts](Generic[Unpack[Us]]): # E: Generic[...] base class is redundant \
# E: Can only use one type var tuple in a class def
pass
[builtins fixtures/tuple.pyi]

[case testPEP695MultipleTypeVarTuplesTypeAlias]
type TA1[*Ts1, *Ts2] = tuple[*Ts1] | tuple[*Ts2] # E: Can only use one TypeVarTuple in a type alias
type TA2[T, *Ts1, *Ts2] = tuple[T, *Ts1, *Ts2] # E: Can only use one TypeVarTuple in a type alias \
# E: More than one variadic Unpack in a type is not allowed
type TA3[*Ts1, T, *Ts2] = tuple[*Ts1, T, *Ts2] # E: Can only use one TypeVarTuple in a type alias \
# E: More than one variadic Unpack in a type is not allowed
type TA4[*Ts] = tuple[*Ts] # OK - single TypeVarTuple is fine
[builtins fixtures/tuple.pyi]
[typing fixtures/typing-full.pyi]


[case testMultipleTypeVarTuplesOldStyle]
# flags: --python-version 3.12
from typing import Union
from typing_extensions import TypeVarTuple, Unpack

Ts1 = TypeVarTuple("Ts1")
Ts2 = TypeVarTuple("Ts2")

TA = Union[tuple[*Ts1], tuple[*Ts2]] # E: Can only use one TypeVarTuple in a type alias
[builtins fixtures/tuple.pyi]
[typing fixtures/typing-full.pyi]
9 changes: 6 additions & 3 deletions test-data/unit/check-typevar-tuple.test
Original file line number Diff line number Diff line change
Expand Up @@ -725,15 +725,18 @@ Ts = TypeVarTuple("Ts")
Us = TypeVarTuple("Us")
class G(Generic[Unpack[Ts]]): ...

A = Tuple[Unpack[Ts], Unpack[Us]] # E: More than one variadic Unpack in a type is not allowed
A = Tuple[Unpack[Ts], Unpack[Us]] # E: Can only use one TypeVarTuple in a type alias \
# E: More than one variadic Unpack in a type is not allowed
x: A[int, str]
reveal_type(x) # N: Revealed type is "tuple[builtins.int, builtins.str]"

B = Callable[[Unpack[Ts], Unpack[Us]], int] # E: More than one variadic Unpack in a type is not allowed
B = Callable[[Unpack[Ts], Unpack[Us]], int] # E: Can only use one TypeVarTuple in a type alias \
# E: More than one variadic Unpack in a type is not allowed
y: B[int, str]
reveal_type(y) # N: Revealed type is "def (builtins.int, builtins.str) -> builtins.int"

C = G[Unpack[Ts], Unpack[Us]] # E: More than one variadic Unpack in a type is not allowed
C = G[Unpack[Ts], Unpack[Us]] # E: Can only use one TypeVarTuple in a type alias \
# E: More than one variadic Unpack in a type is not allowed
z: C[int, str]
reveal_type(z) # N: Revealed type is "__main__.G[builtins.int, builtins.str]"
[builtins fixtures/tuple.pyi]
Expand Down