[mypyc] fix: builder crashes on 3-arg range(x, y, z) if step isnt foldable
#20098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobTheBuidler
changed the title
range(x, y, z) if step isnt foldable
BobTheBuidler
commented
Oct 21, 2025
| if len(expr.args) == 3: | ||
| step = builder.extract_int(expr.args[2]) | ||
| assert step is not None | ||
| if step == 0: |
There was a problem hiding this comment.
we no longer need to check this because we validate that it isn't None or 0 in our new if-check. 0 now falls back to the standard implementation where it fails normally
A5rocks
reviewed
Oct 22, 2025
| is_range_ref(expr.callee) | ||
| and ( | ||
| len(expr.args) <= 2 | ||
| or (len(expr.args) == 3 and builder.extract_int(expr.args[2]) is not None) |
There was a problem hiding this comment.
Huh, why did this fail with an assertion error? (I'm not used to mypyc...)
There was a problem hiding this comment.
Yeh, I'm realizing while re-reading this that it doesn't
I discovered this assert when working on #20100 and made this PR as an intermediate step which could be merged in before the full feature.
In hindsight I suppose this is no longer necessary, but I'll leave it open so maintainers can decide if we want to merge it before #20100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3-arg call to
builtins.rangecurrently crashes mypyc if the 3rd argument's Expression isn't constant-foldable, withAssertionErrorwith no message.This PR fixes it.
I also got rid of some builder error which doesn't seem necessary but can put it back if it still serves a purpose even with the new generic fallback.