Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better tox configuration #15777

Merged
merged 3 commits into from
Jul 29, 2023
Merged

Better tox configuration #15777

merged 3 commits into from
Jul 29, 2023

Conversation

sobolevn
Copy link
Member

It solves two problems:

  1. fix_annotate and async_matrix were removed in Remove more unused scripts #15728
  2. It is better to reuse stuff like runtests.py not to rewrite the same command we already have

AlexWaygood
AlexWaygood reviewed Jul 29, 2023
View reviewed changes
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

hauntsaninja
hauntsaninja approved these changes Jul 29, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. And great catch, Alex!

@sobolevn sobolevn merged commit 710ad44 into master Jul 29, 2023
@sobolevn sobolevn deleted the better-tox branch July 29, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @hauntsaninja @AlexWaygood