Describe how to annotate a function with return type depending on a flag #13884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tional argument I could not find how to do this in the documentation, but eventually saw the example in python#6580 (comment)
sobolevn
reviewed
Oct 21, 2022
docs/source/more_types.rst
Outdated
|
|
||
| # This overload variant applies when "rounded" is omitted or set to False. | ||
| @overload | ||
| def pi(rounded: Literal[False] = ...) -> float: ... |
There was a problem hiding this comment.
This is not correct. This function will always be matched. Without a default should be the first one.
There was a problem hiding this comment.
I’m happy to change this, but at least in this case, both overloads are apparently matched. I tested with this file:
from typing import overload, Literal
@overload
def pi(rounded: Literal[False] = ...) -> float: ...
@overload
def pi(rounded: Literal[True]) -> int: ...
def pi(rounded=False):
return 3 if rounded else 3.14159
reveal_type(pi(rounded=False))
reveal_type(pi())
reveal_type(pi(rounded=True))mypy 0.982 tells me:
default.py:12: note: Revealed type is "builtins.float"
default.py:13: note: Revealed type is "builtins.float"
default.py:14: note: Revealed type is "builtins.int"
Swapping the order of the overloads doesn’t change the output. There’s also no warning about shadowing, wouldn’t that be printed otherwise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find how to do this in the documentation, but eventually saw the example in
#6580 (comment)
Reading this helped me improve my mental model of how overloads work, and perhaps others would benefit as well.