stubtest: Use module_name for error reporting
#13341
Closed
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
requested changes
Aug 6, 2022
| # TODO: find out how we can get filenames from other nodes: | ||
| if isinstance(self.stub_object, nodes.TypeInfo): | ||
| stub_file = os.path.abspath( | ||
| self.stub_object.module_name.replace(".", os.path.sep) + ".pyi" |
Collaborator
There was a problem hiding this comment.
This might not be accurate. Sometimes stubtest's definitions come from .py files (e.g. with packages that have mixed inline types and stubs). While it's rare for such definitions to be involved in errors, it's possible, and it would be very confusing if we lied.
Collaborator
There was a problem hiding this comment.
It's also not necessarily the case that the stubs are relative to the current directory. They could be installed
Member
Author
There was a problem hiding this comment.
yes, this is more complex than I thought!
Collaborator
|
Alternative PR: #13342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a
TODOitem for this.My solution is not 100% complete, but it is something.
Getting path from
FuncDef/ etc is pretty hard.Showcase:
