Add guidelines for C API return values #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markshannon
approved these changes
Jun 23, 2023
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Looks good to me, as a first step.
vstinner
reviewed
Jun 23, 2023
CAM-Gerlach
reviewed
Jun 23, 2023
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
A couple small textual tweaks, otherwise LGTM
Co-authored-by: C.A.M. Gerlach <[email protected]>
CAM-Gerlach
approved these changes
Jun 23, 2023
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
LGTM, thanks @erlend-aasland !
This was referenced Jun 24, 2023
Contributor
Author
|
Unless there are further remarks, I consider landing this early the coming week. |
Contributor
Author
|
Thanks for the reviews! FTR, I also got a thumbs up by Thomas Wouters for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-devguide--1123.org.readthedocs.build/