-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-99593: Add tests for Unicode C API #99594
Conversation
serhiy-storchaka
commented
Nov 19, 2022
•
edited by bedevere-bot
Loading
edited by bedevere-bot
- Issue: Add tests for Unicode C API #99593
I have found a bug during testing. I'll extract it into a separate issue later. I'll write the remaining tests after some rest. |
b6bfd11
to
8bf0e29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want me to review this PR, can you please split it into smaller PR? Like start with a shorter PR, wait until it's merged, then move to the next one.
I'll split it on three parts:
|
Are you talking about creating 3 PRs modifying the same files, or do you consider to have separated C and Python files for "higher-level C API corresponding to str methods"? Maybe it's just fine to put most "unicode" tests in "unicode.c" and "unicode.py" tests. |
As you suggested, I'll add codecs tests in a separate Python file. The rest of tests will be in All wrappers will be defined in |
Since part 1 and 2 are merged, and part 3 (gh-104728) is in the queue, I recon we can close this :) |