Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-98831: Add some macros definitions to bytecodes.c to reduce IDE warnings. #99093

Merged
merged 1 commit into from
Nov 4, 2022
Merged

GH-98831: Add some macros definitions to bytecodes.c to reduce IDE warnings. #99093

merged 1 commit into from
Nov 4, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Nov 4, 2022 •
edited by bedevere-bot
Loading

Reduces the number of red/squiggly underlines.

@bedevere-bot bedevere-bot mentioned this pull request Nov 4, 2022
Closed
@gvanrossum gvanrossum merged commit 7a020b8 into python:main Nov 4, 2022
@gvanrossum gvanrossum deleted the clarify-bytecodes-macros branch November 4, 2022 23:37
@brandtbucher
Copy link
Member

It might make more sense to put all of this stuff (including #includes and things like binary_ops) in one header to be shared between both files. Keeping them in sync seems like it might not scale well.

@gvanrossum
Copy link
Member

Not a bad idea. Though not everything can be put in such a header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markshannon @brandtbucher @gvanrossum @bedevere-bot