Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-96078: os.sched_yield release the GIL while calling sched_yield(2). #97965

Merged
merged 1 commit into from
Oct 6, 2022
Merged

gh-96078: os.sched_yield release the GIL while calling sched_yield(2). #97965

merged 1 commit into from
Oct 6, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 6, 2022 •
edited by bedevere-bot
Loading

@corona10 corona10 requested a review from vstinner October 6, 2022 15:47
@corona10
Copy link
Member Author

corona10 commented Oct 6, 2022 


(.oss) corona10@python-dev:~/cpython$ ./python -m test test_posix -R 3:3
0:00:00 load avg: 0.02 Run tests sequentially
0:00:00 load avg: 0.02 [1/1] test_posix
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 9.1 sec
Tests result: SUCCESS

kumaraditya303
kumaraditya303 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminp benjaminp merged commit b9d2e81 into python:main Oct 6, 2022
carljm added a commit to carljm/cpython that referenced this pull request Oct 6, 2022
@carljm
Merge branch 'main' into dictwatch
e5d2169 
* main:
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
  pythongh-94808: Coverage: Test that maximum indentation level is handled (python#95926)
@corona10 corona10 deleted the gh-96078 branch October 7, 2022 00:34
@corona10 corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 7, 2022
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-98013 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 7, 2022
@bedevere-bot
Copy link

GH-98014 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@corona10 @miss-islington
fixes pythongh-96078: os.sched_yield release the GIL while calling sc…
920e025 
…hed_yield(2). (pythongh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@corona10 @miss-islington
fixes pythongh-96078: os.sched_yield release the GIL while calling sc…
4a38944 
…hed_yield(2). (pythongh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @corona10
fixes gh-96078: os.sched_yield release the GIL while calling sched_yi…
e39b511 
…eld(2). (gh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @corona10
fixes gh-96078: os.sched_yield release the GIL while calling sched_yi…
11945f2 
…eld(2). (gh-97965)

(cherry picked from commit b9d2e81)

Co-authored-by: Dong-hee Na <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
415ed49 
* main:
  pythonGH-97002: Prevent `_PyInterpreterFrame`s from backing more than one `PyFrameObject` (pythonGH-97996)
  pythongh-97973: Return all necessary information from the tokenizer (pythonGH-97984)
  fixes pythongh-96078: os.sched_yield release the GIL while calling sched_yield(2). (pythongh-97965)
  pythongh-65961: Do not rely solely on `__cached__` (pythonGH-97990)
  pythongh-97850: Remove the open issues section from the import reference (python#97935)
  Docs: pin sphinx-lint (pythonGH-97992)
  pythongh-94590: add signatures to operator itemgetter, attrgetter, methodcaller (python#94591)
  Add Pynche's move to the What's new in 3.11 (python#97974)
  pythongh-97781: Apply changes from importlib_metadata 5. (pythonGH-97785)
  pythongh-86482: Document assignment expression need for ()s (python#23291)
  pythongh-97943: PyFunction_GetAnnotations should return a borrowed reference. (python#97949)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@corona10 @mpage
fixes pythongh-96078: os.sched_yield release the GIL while calling sc…
0c970bd 
…hed_yield(2). (pythongh-97965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corona10 @miss-islington @bedevere-bot @kumaraditya303 @benjaminp