Skip to content

Conversation

@tiran
Copy link
Member

@tiran tiran commented Aug 13, 2022

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly look good. Generally TCL/TK => Tcl/Tk. Also, there are some lines with (assuming unintended) leading white-space, and some with trailing white-space.

Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more misspellings of Tcl/Tk, otherwise LGTM.

Co-authored-by: Erlend E. Aasland <[email protected]>
@tiran tiran changed the title gh-95957: Add instructions for TCL/TK and OpenSSL on RHEL/CentOS 7 gh-95957: Add instructions for Tcl/Tk and OpenSSL on RHEL/CentOS 7 Aug 16, 2022
@tiran tiran marked this pull request as ready for review August 16, 2022 11:08
@tiran tiran merged commit ab4d729 into python:main Aug 16, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@tiran tiran deleted the gh-95957-tcltk-pc branch August 16, 2022 11:44
@miss-islington
Copy link
Contributor

Sorry @tiran, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ab4d72954f3c3fe4bdf51dc6a9cf0ed38f210a68 3.11

@tiran tiran added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Aug 16, 2022
@miss-islington
Copy link
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-96022 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2022
…S 7 (pythonGH-95964)

Co-authored-by: Erlend E. Aasland <[email protected]>
(cherry picked from commit ab4d729)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 16, 2022
miss-islington added a commit that referenced this pull request Aug 18, 2022
…H-95964)

Co-authored-by: Erlend E. Aasland <[email protected]>
(cherry picked from commit ab4d729)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants